initial shellcheck tests #268

Closed
austin987 wants to merge 4 commits from sc into master
austin987 commented 2020-12-26 09:09:20 +01:00 (Migrated from github.com)

I started on this a while back, but got sidetracked (and wanted to fix outstanding issues first).

However, since SolidHal/PrawnOS@0bd5575b0b broke install for me, and would easily have been caught by shellcheck, I revisited it.

This is an initial pass. It currently ignores SC2068 (unquoted variables), and style issues in favor of only flagging error level issues.

To get that level of checking, however, I had to fix some outstanding issues, first ;).

@SolidHal

I started on this a while back, but got sidetracked (and wanted to fix outstanding issues first). However, since https://github.com/SolidHal/PrawnOS/commit/0bd5575b0b84bcf469cd0b94351c10f1a0a459f9 broke install for me, and would easily have been caught by shellcheck, I revisited it. This is an initial pass. It currently ignores SC2068 (unquoted variables), and style issues in favor of only flagging error level issues. To get that level of checking, however, I had to fix some outstanding issues, first ;). @SolidHal
austin987 commented 2020-12-26 23:02:36 +01:00 (Migrated from github.com)

Marking WIP while I look closer at something.

Marking WIP while I look closer at something.
austin987 commented 2020-12-28 02:38:13 +01:00 (Migrated from github.com)

Removing WIP, the issue I was seeing was unrelated to this.

This can go in.

Removing WIP, the issue I was seeing was unrelated to this. This can go in.
SolidEva commented 2022-07-26 06:57:23 +02:00 (Migrated from github.com)

fixed up the conflicts, will merge when checks pass

fixed up the conflicts, will merge when checks pass
SolidEva (Migrated from github.com) approved these changes 2022-07-26 06:57:33 +02:00
SolidEva commented 2022-07-26 07:30:22 +02:00 (Migrated from github.com)

Merged this in 05746fcbb0

Merged this in 05746fcbb092715d48fc1cc9af4963341eaac8dd

Pull request closed

Sign in to join this conversation.
No description provided.